Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update external-datastore.md #646

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Update external-datastore.md #646

merged 2 commits into from
Sep 3, 2024

Conversation

evilnick
Copy link
Contributor

@evilnick evilnick commented Sep 2, 2024 •
edited
Loading

Fixes #553

@evilnick evilnick requested a review from a team as a code owner September 2, 2024 14:28
louiseschmidtgen
louiseschmidtgen approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick!

bschimke95
bschimke95 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evilnick evilnick merged commit 0b5ccd7 into main Sep 3, 2024
19 checks passed
@evilnick evilnick deleted the evilnick-patch-1 branch September 3, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

@louiseschmidtgen louiseschmidtgen louiseschmidtgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: Wrong parameters for the external etcd datastore bootstrap configuration
3 participants
@evilnick @louiseschmidtgen @bschimke95